Skip to content

release-25.4: roachtest: ignore flaky npgsql test#167480

Merged
trunk-io[bot] merged 1 commit intocockroachdb:release-25.4from
bghal:blathers/backport-release-25.4-167474
Apr 6, 2026
Merged

release-25.4: roachtest: ignore flaky npgsql test#167480
trunk-io[bot] merged 1 commit intocockroachdb:release-25.4from
bghal:blathers/backport-release-25.4-167474

Conversation

@bghal
Copy link
Copy Markdown
Contributor

@bghal bghal commented Apr 3, 2026

Backport 1/1 commits from #167474 on behalf of @bghal.


The Npgsql.Tests.CommandTests(NonMultiplexing).Cancel_async_soft has
been timing out.

Epic: none
Fixes: #167069

Release note: None


Release justification:

The `Npgsql.Tests.CommandTests(NonMultiplexing).Cancel_async_soft` has
been timing out.

Epic: none
Fixes: cockroachdb#167069

Release note: None
@bghal bghal force-pushed the blathers/backport-release-25.4-167474 branch from 778c937 to a56cce9 Compare April 3, 2026 15:27
@blathers-crl blathers-crl Bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 3, 2026
@blathers-crl blathers-crl Bot requested a review from rafiss April 3, 2026 15:27
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Apr 3, 2026

Thanks for opening a backport.

Before merging, please confirm that it falls into one of the following categories (select one):

  • Non-production code changes OR fixes for serious issues. Non-production includes test-only changes, build system changes, etc. Serious issues are defined in the policy as correctness, stability, or security issues, data corruption/loss, significant performance regressions, breaking working and widely used functionality, or an inability to detect and debug production issues.
  • Other approved changes. These changes must be gated behind a disabled-by-default feature flag unless there is a strong justification not to. Reference the approved ENGREQ ticket in the PR body (e.g., "Fixes ENGREQ-123").

Add a brief release justification to the PR description explaining your selection.

Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy.

All backports must be reviewed by the TL and EM for the owning area.

@trunk-io
Copy link
Copy Markdown
Contributor

trunk-io Bot commented Apr 3, 2026

😎 Merged successfully - details.

@blathers-crl blathers-crl Bot added backport Label PR's that are backports to older release branches T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Apr 3, 2026
@blathers-crl
Copy link
Copy Markdown

blathers-crl Bot commented Apr 3, 2026

❌ PR #167480 does not comply with backport policy

Confidence: high
Explanation: The PR involves modifications to a production file (pkg/cmd/roachtest/tests/npgsql_blocklist.go), specifically in the roachtest area, which aligns with development tools according to the backport policy. These files are used for configuring and running system tests, which although directly impacting test environments rather than production code, are crucial in maintaining the quality of the release. However, the PR lacks a complete 'Release justification' which is necessary for exempting it from the backport policy's critical bug or feature flag requirements. The PR attempts to address a flaky test by modifying a blocklist, a change typically not associated with critical bugs or new feature flags. Therefore, it violates the backport policy due to the absence of a sufficient release justification.
Recommendation: Provide a complete and detailed release justification in the PR body that aligns with the backport policy or reconsider the backport.

ENGREQ Check Failed: Please check one of the backport category checkboxes.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@blathers-crl blathers-crl Bot added the backport-test-only Used to denote the backport has only non-production changes label Apr 3, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 6, 2026

/trunk merge

@trunk-io trunk-io Bot merged commit 74701b3 into cockroachdb:release-25.4 Apr 6, 2026
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches backport-test-only Used to denote the backport has only non-production changes blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) v25.4.10

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants